Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: xml: add method to extract all the channels ......................................................................
vm: xml: add method to extract all the channels The VM code needs to iterate on all the agent channels to possibly fix the links. However, it doesn't need, nor it should, directly parse the XML again, because we are moving all the XML-related processing into the vmxml module. This patch is another step on this direction. Please note that this patch mostly moves code around. More aggressive refactoring is planned for future work. Along the way, we bootstrap the vdsm/virt/vmxml.py test module, because vmTests.py is too big already. Change-Id: I145363ee150b3ab4e527af38c1a232431757acb1 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31450 Reviewed-by: Vinzenz Feenstra <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/Makefile.am A tests/vmXmlTests.py M vdsm/virt/vm.py M vdsm/virt/vmxml.py 4 files changed, 78 insertions(+), 12 deletions(-) Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/31450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I145363ee150b3ab4e527af38c1a232431757acb1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
