mooli tayer has posted comments on this change. Change subject: Additional tool tests for exposed functions ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31940/1/tests/toolTests.py File tests/toolTests.py: Line 84: def configure(self): Line 85: pass Line 86: Line 87: def removeConf(self): Line 88: pass unite 3 x MockModuleConfigurators to one? We can pass parameters/functions to them. Or you can create you False/True mocks in functions, just Have one impl. Line 89: Line 90: Line 91: class ConfiguratorTests(TestCase): Line 92: -- To view, visit http://gerrit.ovirt.org/31940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae0f98a9218b38c94aa003fea832d6795e7f0f23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
