mooli tayer has posted comments on this change. Change subject: Use stdout for regular output message in removeConf func ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31941/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 152: failed = False Line 153: for c in args.modules: Line 154: try: Line 155: c.removeConf() Line 156: sys.stdout.write( This makes me think that its weird that here (remove-config) we catch unexpected exception but in configure we don't. Line 157: "removed configuration of module %s successfully\n" % Line 158: c.getName() Line 159: ) Line 160: -- To view, visit http://gerrit.ovirt.org/31941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
