mooli tayer has posted comments on this change.

Change subject: el6_tests: fix toolTests to use VdsmTestCase so that assertIn 
is available
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/31968/2/tests/toolTests.py
File tests/toolTests.py:

Line 27: from vdsm.tool import UsageError
Line 28: from vdsm.tool import upgrade
Line 29: from vdsm import utils
Line 30: import monkeypatch
Line 31: from testlib import VdsmTestCase
nice to know about this.

maybe switch all existing TestCase to work with testlib?
Line 32: from unittest import TestCase
Line 33: import tempfile
Line 34: import os
Line 35: import shutil


-- 
To view, visit http://gerrit.ovirt.org/31968
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb564320db9db1b3349c7fbb87bc63a8a044c6b2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to