Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: isolate VmDevice xml generation method ......................................................................
vdsm: isolate VmDevice xml generation method VmDevice class uses helper function 'createXmlElem' to ease generating of XML for devices. This patch moves the function to xmldom in the form of new parent class for VmDevice, separating the logic and xml generation. (inspired by http://gerrit.ovirt.org/#/c/17694/) Change-Id: I026917641da7e1a55b15ae3238ee545023cf129e Signed-off-by: Martin Polednik <[email protected]> Reviewed-on: http://gerrit.ovirt.org/29249 Reviewed-by: Francesco Romani <[email protected]> Tested-by: Martin Polednik <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py M vdsm/virt/vmxml.py 2 files changed, 30 insertions(+), 24 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/29249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I026917641da7e1a55b15ae3238ee545023cf129e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
