Antoni Segura Puimedon has posted comments on this change. Change subject: ipwrapper: event monitor, docs update + proc.wait ......................................................................
Patch Set 5: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31854/5/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 603: mon = Monitor() Line 604: mon.start() Line 605: for event in mon: Line 606: handle event Line 607: mon.stop() this code snippet is intended for a thread that would just be designed to run forever, so you'd never reach mon.stop(). For stopping the monitor of such program you'd need something custom like the thread having a finishing boolean that when checked stops the monitor or so. Line 608: Line 609: Note that the underlying `ip monitor` process is killed when its controlled Line 610: thread dies, so as not to leave stray processes when Vdsm crahsed. Line 611: """ -- To view, visit http://gerrit.ovirt.org/31854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e7ed0a0dea368206b7ee94482251ae5e4fa7259 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
