Dan Kenigsberg has submitted this change and it was merged. Change subject: domainMonitor: Fix unsafe status handling ......................................................................
domainMonitor: Fix unsafe status handling DomainMonitor status was updated in a unsafe way, assuming that another thread will never ask the status in the middle of an update. The code was written as if creating a new status object is expensive operation that should be avoided. Instead of having long living status object in the monitor, I create new forozen copy each monitor interval (10 seconds). The frozen copy ensure that careless developers trying to modify a status will get what they deserve. Change-Id: If4affb67b6e65382dc4e55ebad9443e2722f2773 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/29014 Reviewed-by: Yoav Kleinberger <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> --- M tests/Makefile.am A tests/domainMonitorTests.py M vdsm/storage/domainMonitor.py 3 files changed, 59 insertions(+), 14 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Yoav Kleinberger: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4affb67b6e65382dc4e55ebad9443e2722f2773 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
