Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: do not use _dom for powerdown ......................................................................
vm: do not use _dom for powerdown We must avoid the proliferation of trivial helper methods, but using private VM fields across modules is a greater evil, even if modules are part of the same package and affine, like vm.py and vmpowerdown.py To avoid that, a new simple method is added to request clean shutdown of a VM through ACPI events. Change-Id: Ia99a8a557b9bbbaf693eb0e89aa9f39c0ecce400 Bug-Url: https://bugzilla.redhat.com/557125 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31901 Reviewed-by: Michal Skrivanek <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> --- M vdsm/virt/vm.py M vdsm/virt/vmpowerdown.py 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia99a8a557b9bbbaf693eb0e89aa9f39c0ecce400 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
