Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: simplify the shutdown exit reason ......................................................................
vm: simplify the shutdown exit reason A VM could be cleanly shutdown in two ways, either from inside (user shutdown) or from engine (admin shutdown). In turn, the shutdown process can involve various shutdown methods (guest agent, acpi, forced). Currently we use a couple of booleans to detect all the various cases, but this is clumsy and some paths aren't well covered, so wrong states may be reported. This patch simplify the reporting by adding an explicit, private, 'shutdownReason' field. The main reason for the cleanup is to fix a wrong exit reason reporting. Previously, USER_SHUTDOWN was incorrectly reported instead of ADMIN_SHUTDOWN. This patch fixes this. Bug-Url: https://bugzilla.redhat.com/557125 Change-Id: Id03e38fe897d3b36fa7fedc016c2420f67d28385 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31902 Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/31902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id03e38fe897d3b36fa7fedc016c2420f67d28385 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
