Francesco Romani has posted comments on this change. Change subject: Live Merge: Get volume chain for multiple drives ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/31366/8/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5521: diskXML = lookupDeviceXMLByAlias(domXML, alias) Line 5522: if not diskXML: Line 5523: continue Line 5524: volChain = [] Line 5525: while True: > I've broken it out for the next submission. I'm not convinced it looks any Looks a bit better to me :) Line 5526: sourceXML = findElement(diskXML, 'source') Line 5527: if not sourceXML: Line 5528: break Line 5529: sourceAttr = ('file', 'dev')[drive.blockDev] -- To view, visit http://gerrit.ovirt.org/31366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93d5a641b0814e3764c70bea8a6c1910a821adcc Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
