Federico Simoncelli has posted comments on this change. Change subject: qemuimg: Handle new output format ......................................................................
Patch Set 7: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/27552/7/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 94: row = INFO_OPTFIELDS_STARTIDX Line 95: for field, filterFn in (('clustersize', int), ('backingfile', str)): Line 96: try: Line 97: info[field] = filterFn(__iregexSearch(field, out[row])) Line 98: row = row + 1 Not a big deal but should this be outside of the try/except? (maybe in else?) Line 99: except (_RegexSearchError, IndexError): Line 100: pass Line 101: Line 102: return info -- To view, visit http://gerrit.ovirt.org/27552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic229198ab7c2bb9743bdf8629416131186115431 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
