Nir Soffer has posted comments on this change. Change subject: lvm: Exclude faulty devices from lvm long filter ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31875/2/vdsm/storage/multipath.py File vdsm/storage/multipath.py: Line 389: if status.get(slave) == "active"] Line 390: if not active: Line 391: log.warning("Skipping device %s - no active slave", guid) Line 392: continue Line 393: log.debug("Found device %s %s", guid, active) > Isn't this too verbose? Yea, we can probably disable this log. Line 394: yield os.path.join(devicemapper.DMPATH_PREFIX, guid) Line 395: Line 396: Line 397: def getMPDevsIter(): -- To view, visit http://gerrit.ovirt.org/31875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7a973bcefa95813fdc289847760c0955aca30c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
