Alon Bar-Lev has posted comments on this change. Change subject: Deprecated string.join() replaced ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31897/2/vds_bootstrap/setup File vds_bootstrap/setup: Line 188: else: Line 189: execfn += [random_num] Line 190: execfn.append(str(int(rebootAfterInstallation))) Line 191: logging.debug("trying to run %s script cmd = '%s'", Line 192: script, ' '.join(execfn)) it is debug... you can just put the execfn... :) Line 193: proc = subprocess.Popen(execfn) Line 194: proc.communicate() Line 195: if proc.returncode == 0: Line 196: return True -- To view, visit http://gerrit.ovirt.org/31897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d16939a5d1d4518d1d91a525d8b403b3be12787 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
