Francesco Romani has posted comments on this change.

Change subject: Add API.VM.setIoTune
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

seems OK with the bumped version in the schema

http://gerrit.ovirt.org/#/c/30076/6/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 7510: #            describing the new settings
Line 7511: # Returns:
Line 7512: # Status code
Line 7513: #
Line 7514: # Since: 4.15.0
please bump version
Line 7515: ##
Line 7516: {'command': {'class': 'VM', 'name': 'setIoTune'},
Line 7517:  'data': {'vmID': 'UUID', 'tunables': ['VmDiskDeviceTuneParams']},
Line 7518:  'returns': 'TaskStatus'}


-- 
To view, visit http://gerrit.ovirt.org/30076
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to