Ondřej Svoboda has posted comments on this change. Change subject: iproute2, dhclient: Deal with v4/v6 protocols separately ......................................................................
Patch Set 5: (1 comment) The condition is fixed by http://gerrit.ovirt.org/#/c/32168/ http://gerrit.ovirt.org/#/c/31104/5/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 565: a link-local address necessary for DHCPv6 functionality. Line 566: """ Line 567: family = ['-%s' % family] if family in (4, 6) else [] Line 568: command = [_IP_BINARY.cmd] + family + ['addr', 'flush', 'dev', dev] Line 569: if family == 6: > family can be ['-6'], but never equal 6 Thank you for noticing! :-) Line 570: command += ['scope', 'global'] Line 571: _execCmd(command) Line 572: Line 573: -- To view, visit http://gerrit.ovirt.org/31104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5708c4db6f6d450536bd243a0475164b89f46f93 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: jian wang <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
