Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: Test against the correct value of variable 'family' ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/32168/1/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 563: If the 'family' parameter is different than 4 or 6, flush all addresses. Line 564: If it is 6, remove only globally-routable addresses to preserve Line 565: a link-local address necessary for DHCPv6 functionality. Line 566: """ Line 567: family = ['-%s' % family] if family in (4, 6) else [] let's learn out lesson, and not override the same variable! have this statement assign to a family_args or some other name. Line 568: command = [_IP_BINARY.cmd] + family + ['addr', 'flush', 'dev', dev] Line 569: if family == ['-6']: Line 570: command += ['scope', 'global'] Line 571: _execCmd(command) -- To view, visit http://gerrit.ovirt.org/32168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f60f32a09d92ad7ee39bf343e4331bd3e43a14b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
