Dan Kenigsberg has posted comments on this change. Change subject: vm: Automatically add a serial port for a console device ......................................................................
Patch Set 7: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/25979/7//COMMIT_MSG Commit Message: Line 6: Line 7: vm: Automatically add a serial port for a console device Line 8: Line 9: Without a serial device the console support does not work for Line 10: linux systems. We switch from virtio to serial and append a serial linux systems -> Linux guests but is that really true? In what way "does it not work"? I thought that virtio console was problematic on Windows, and actually fine for Linux. Line 11: port if a console device was defined. Line 12: Line 13: Change-Id: Ifa7b02a7bcaad63017c35c811a194fa42e2b694f Line 7: vm: Automatically add a serial port for a console device Line 8: Line 9: Without a serial device the console support does not work for Line 10: linux systems. We switch from virtio to serial and append a serial Line 11: port if a console device was defined. defined -> requirested. Line 12: Line 13: Change-Id: Ifa7b02a7bcaad63017c35c811a194fa42e2b694f Line 8: Line 9: Without a serial device the console support does not work for Line 10: linux systems. We switch from virtio to serial and append a serial Line 11: port if a console device was defined. Line 12: Have you considered possible issues for guest OS that sees a new implementation for its console if started on a 3.6 vdsm? Please mention that the effects are tolerable. (I suppose not oVirt users cares about console throughput enough to merit virtio) Line 13: Change-Id: Ifa7b02a7bcaad63017c35c811a194fa42e2b694f -- To view, visit http://gerrit.ovirt.org/25979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7b02a7bcaad63017c35c811a194fa42e2b694f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
