Dan Kenigsberg has posted comments on this change. Change subject: vdsm | netinfo : Return Mac of bond slaves in lower case ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Minor comment about the commit message. Other than that, the patch seems fine. http://gerrit.ovirt.org/#/c/31888/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-08-25 12:43:46 +0300 Line 4: Commit: Genadi Chereshnya <[email protected]> Line 5: CommitDate: 2014-08-25 12:43:46 +0300 Line 6: Line 7: vdsm | netinfo : Return Mac of bond slaves in lower case There's no need for the "vdsm" prefix. It's the vdsm project, so it adds nothing. Please drop the space before the colon, too. Line 8: Line 9: getVdsCaps returns MAC of all interfaces in lower case and for bond slaves Line 10: it returned it in upper cases - fixing inconsistency Line 11: -- To view, visit http://gerrit.ovirt.org/31888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Genadi Chereshnya <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Genadi Chereshnya <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
