Francesco Romani has posted comments on this change. Change subject: Live Merge: add reconcileVolumeChain verb ......................................................................
Patch Set 5: Code-Review+1 (1 comment) just one silly comment inside http://gerrit.ovirt.org/#/c/31788/5/vdsm/storage/image.py File vdsm/storage/image.py: Line 1136: if vol.volUUID not in actualChain: Line 1137: subChain.insert(0, vol.volUUID) Line 1138: elif len(subChain) > 0: Line 1139: break Line 1140: if len(subChain) == 0: only if you resubmit: I believe if not subChain: is clearer Line 1141: return Line 1142: self.log.debug("unlinking subchain: %s" % subChain) Line 1143: Line 1144: sdDom = sdCache.produce(sdUUID=sdUUID) -- To view, visit http://gerrit.ovirt.org/31788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8927a42d2bc9adcf7c6b26babb327a00e91e49e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
