Yaniv Bronhaim has submitted this change and it was merged. Change subject: tool: Create configurators once ......................................................................
tool: Create configurators once Commit e5e80540e8 replaced the configurators dict with a function, creating a configuration dict on each call. The code added in this commit invoke the function many times for each run on the tool, creating 10's of instances of the configurators. This change is not needed to acomplish the purpuse of that patch, and is rather pointless. This patch reverts the unrelated change, keeping the configurations in a module constant. This change also simplify the tests. Change-Id: I6e0e258dc28557661bf85734f000e43f20b1e512 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/31739 Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/32204 Tested-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Antoni Segura Puimedon <asegu...@redhat.com> Reviewed-by: mooli tayer <mta...@redhat.com> --- M lib/vdsm/tool/configurator.py M tests/toolTests.py 2 files changed, 23 insertions(+), 24 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved Antoni Segura Puimedon: Looks good to me, but someone else must approve mooli tayer: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e0e258dc28557661bf85734f000e43f20b1e512 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
