Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: changing root checking in configurator. ......................................................................
vdsm-tool: changing root checking in configurator. Checking for root as we currently do in configure of libvirt and sanlock is not enough. Currently this will fail during the isConfigured() check since it does not have premissions to the files it attempts to check: "OSError: No such file or directory: /etc/libvirt/libvirtd.conf" It is easy to see that this check is needed for all the exposed methods of configurator. I'm suggesting to do it in the exposed verbs in a uniform manner. Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55 Signed-off-by: Mooli Tayer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31293 Reviewed-by: Dima Kuznetsov <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/__init__.py M lib/vdsm/tool/configurator.py M lib/vdsm/tool/configurators/libvirt.py M lib/vdsm/tool/configurators/sanlock.py 4 files changed, 20 insertions(+), 7 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dima Kuznetsov: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
