Yaniv Bronhaim has posted comments on this change. Change subject: getVMFullList hangs into infinite loop when handing many VMs ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/32290/3//COMMIT_MSG Commit Message: Line 14: We use numSent in AsyncDispatcher#handle_write to decide whether we need Line 15: to process current buffer or we are done. When numSent is -1 we get into Line 16: infinite loop due to: Line 17: Line 18: self._outbuf = data[numSent:] its not part of the patch.. is it the socket.send() call which does all the above ? Line 19: Line 20: We split the data and attempt to send it one more time but we still get Line 21: -1. We need to get to poll loop to continue. Line 22: Line 18: self._outbuf = data[numSent:] Line 19: Line 20: We split the data and attempt to send it one more time but we still get Line 21: -1. We need to get to poll loop to continue. Line 22: we need to get s\to\the loop to continue? Line 23: Line 24: Reviewed-On: http://gerrit.ovirt.org/#/c/32263/ Line 25: Bug-Url: https://bugzilla.redhat.com/1135959 Line 26: Change-Id: Ia728691880771388b6179e85a97df3f303aeddf8 -- To view, visit http://gerrit.ovirt.org/32290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia728691880771388b6179e85a97df3f303aeddf8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
