Francesco Romani has posted comments on this change. Change subject: vdsm: initial split of vm devices ......................................................................
Patch Set 5: Code-Review+1 (1 comment) very nice start. http://gerrit.ovirt.org/#/c/29250/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 748: if attr == 'nicModel' and value == 'pv': Line 749: kwargs[attr] = 'virtio' Line 750: elif attr == 'network' and value == '': Line 751: kwargs[attr] = DUMMY_BRIDGE Line 752: vmdevices.Base.__init__(self, conf, log, **kwargs) let's make use of super() - here and below, in a followup patch. Line 753: self.sndbufParam = False Line 754: self._customize() Line 755: Line 756: def _customize(self): -- To view, visit http://gerrit.ovirt.org/29250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63b602851c17697259e86dfad3a9063447c57e50 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
