Adam Litke has posted comments on this change. Change subject: Live Merge: Simplify pivot flow ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/31849/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5653: if self.doPivot: Line 5654: self.tryPivot() Line 5655: self.vm.log.info("Synchronizing volume chain after live merge " Line 5656: "(job %s)", self.jobId) Line 5657: self.vm._syncVolumeChain(self.drive) > Is this going to call imageSyncVolumeChain once again? Hmm... Well I guess we could skip calling irs.imageSyncVolumeChain in the pivot case (since it has already done its work). We do still need to sync the volume chain in the VM object. But this would add even more knowledge about the internal workings of IRS to the virt code. Line 5658: self.success = True Line 5659: self.vm.log.info("Synchronization completed (job %s)", self.jobId) Line 5660: Line 5661: def isSuccessful(self): -- To view, visit http://gerrit.ovirt.org/31849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e6a9ea7096b5d81f418754d411f135450bf572e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
