Nir Soffer has posted comments on this change. Change subject: tests: Use frozenset instead of set ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31786/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-08-26 19:36:27 +0300 Line 6: Line 7: tests: Use frozenset instead of set Line 8: Line 9: Using frozenset ensure that bad code trying ot mutate the return value > ensures? Correct, will fix. Line 10: of requires() will fail. Line 11: Line 12: Instead of replacing all set(...) calls with frozenset(...), I'm Line 13: creating the frozenset in __init__, so there is no way to create an -- To view, visit http://gerrit.ovirt.org/31786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11835fe49ffcc3e4cbfdbc4272bc31429b6be2e1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
