Dan Kenigsberg has submitted this change and it was merged. Change subject: Live Merge: add reconcileVolumeChain verb ......................................................................
Live Merge: add reconcileVolumeChain verb If a live merge operation is catastrophically interrupted (we completely lose the host on which the VM was running during the merge) engine must have a way to discover what happened by examining storage only. When the active layer was being merged, it's critical to know whether the the pivot completed or not. Choosing the wrong leaf volume could result in data corruption. When an internal volume is being merged the situation is less dire but providing a way for engine to resolve the final status of the merge provides for a substantially better user experience since the snapshot can be unlocked to allow a cold merge to be attempted. This new verb must run on SPM and is only valid for images which are not in use by running VMs. It will use qemu-img to examine the actual volume chain and will correct the vdsm metadata if needed. Finally, the current volume chain is returned. This chain can be used by engine to understand what happened with the interrupted merge command. Change-Id: Ia8927a42d2bc9adcf7c6b26babb327a00e91e49e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127294 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31788 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Piotr Kliczewski <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-on: http://gerrit.ovirt.org/32328 Reviewed-by: Dan Kenigsberg <[email protected]> --- M client/vdsClient.py M vdsm/API.py M vdsm/rpc/BindingXMLRPC.py M vdsm/rpc/Bridge.py M vdsm/rpc/vdsmapi-schema.json M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/sp.py 8 files changed, 163 insertions(+), 23 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Adam Litke: Verified Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8927a42d2bc9adcf7c6b26babb327a00e91e49e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
