Dan Kenigsberg has submitted this change and it was merged. Change subject: setNumberOfCpus marshalling issue ......................................................................
setNumberOfCpus marshalling issue xmlrpc uses vmID twice to construct VM object and to run setNumberOfCpus. In xmlrpc we provide implementation how we instantiate API object and invoke a verb so we do not care how the parameters are used. Whereas in jsonrpc we use "reflection" so we can't use the same parameter twice. Bug-Url: https://bugzilla.redhat.com/1138181 Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Signed-off-by: pkliczewski <[email protected]> Reviewed-on: http://gerrit.ovirt.org/32454 Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/API.py M vdsm/rpc/BindingXMLRPC.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
