Dan Kenigsberg has posted comments on this change. Change subject: ppc: Over ppc arch vdsm reports UNKNOW as operationSystem in getVdsCaps ......................................................................
Patch Set 2: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/32444/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-09-03 22:29:46 -0400 Line 4: Commit: Yaniv Bronhaim <[email protected]> Line 5: CommitDate: 2014-09-04 11:03:35 -0400 Line 6: Line 7: ppc: Over ppc arch vdsm reports UNKNOW as operationSystem in getVdsCaps UNKNOW -> UNKNOWN doublespace -> single space Line 8: Line 9: Vdsm currently check only /etc/redhat-release path which does not exist Line 10: over ppc arch, we should read /etc/ibm_powerkvm-release to retrieve the Line 11: release version Line 5: CommitDate: 2014-09-04 11:03:35 -0400 Line 6: Line 7: ppc: Over ppc arch vdsm reports UNKNOW as operationSystem in getVdsCaps Line 8: Line 9: Vdsm currently check only /etc/redhat-release path which does not exist check->checks But more importantly - this file exists on ppc arch Fedora. It does not exist on the PowerKVM platform. Better be precise here. Line 10: over ppc arch, we should read /etc/ibm_powerkvm-release to retrieve the Line 11: release version Line 12: Line 13: Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3 http://gerrit.ovirt.org/#/c/32444/2/vdsm/caps.py File vdsm/caps.py: Line 65: RHEL = 'RHEL' Line 66: FEDORA = 'Fedora' Line 67: RHEVH = 'RHEV Hypervisor' Line 68: DEBIAN = 'Debian' Line 69: POWER = 'PPC' I think POWERKVM = 'PowerKVM" is a better name ("Power" sounds too generic to me. reminds me of "Word") Line 70: Line 71: Line 72: class AutoNumaBalancingStatus: Line 73: DISABLE = 0 -- To view, visit http://gerrit.ovirt.org/32444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
