Francesco Romani has posted comments on this change. Change subject: vm: enable disk stats collection on recovery ......................................................................
Patch Set 1: Code-Review-1 This issue turned out to be much less severe than I thought. What saves us is that as last step of recovery flow, in clientIF.py:_recoverExistingVms() there is a specific preparePaths() invocation for each recovered VM, which will clean things and starts the collection of the disk stats Why I was confused and thus proposed this change? I was doing stress-test on VDSM with 100Vms with unrealistically frequent polling (each 1s) looking for memleaks, and, as side effect of the above, disk stats for *each* VMs aren't reported until recovery is fully completed. I didn't saw disk stats just after recovery, and during the initial investigation I took the wrong turn and git grep'd for the wrong statement (didn't check properly preparePath, only inside vm.py), hence my error. I apologize for that, I'll make a point to always have a clear and simple reproducer, ready for BZ, before to cry wolf. That said, there is still an issue with disk stats and disk extend being ineffective during *all the recovery phase*, and for code in recovery path being confusing and twisted, but this is much less serious than the issue originally reported. I think is safe to abandon this change, take notes for possible improvements on the recovery flow, and to move on. -- To view, visit http://gerrit.ovirt.org/32406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd7d32373f5a0a7dd4ef88c5a0ad5a9f3d52938c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
