Yoav Kleinberger has posted comments on this change. Change subject: tests: new functional tests for vdsm storage ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/32496/2/tests/functional/testlib/testcontexts/base.py File tests/functional/testlib/testcontexts/base.py: Line 39: logging.info('waiting for "%s"' % description) Line 40: start = time.time() Line 41: for _ in xrange(timeout): Line 42: if predicate(*args, **kwargs): Line 43: logging.info('it took %s seconds' % (time.time() - start)) > Use %0.3f - you are formatting a floating point number and we want to contr Done Line 44: return Line 45: time.sleep(1) Line 46: Line 47: assert False, 'waited %s seconds for "%s" but it did not happen' % (timeout, description) Line 46: Line 47: assert False, 'waited %s seconds for "%s" but it did not happen' % (timeout, description) Line 48: Line 49: def spmStarted(self, poolID): Line 50: self.waitForVDSMToFinishTask() > How about wait_until_task_finish? Do you create task that do not run in vds I made a change in the implementation, so I can now do the self.vdsm.waitForTask - will fix Line 51: masterDomainDirectory = '/rhev/data-center/%s/mastersd' % poolID Line 52: master = os.path.join(masterDomainDirectory, 'master') Line 53: tasks = os.path.join(master, 'tasks') Line 54: vms = os.path.join(master, 'vms') -- To view, visit http://gerrit.ovirt.org/32496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1703e7c1dc223ff707775865cd14c7dd62314caf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
