Nir Soffer has posted comments on this change. Change subject: config: introduce a devel section ......................................................................
Patch Set 1: (2 comments) Looks fine but can do more - I think we can do all changes needed for additional profiler in one step, simplifying review, verification and even backporting. http://gerrit.ovirt.org/#/c/32664/1//COMMIT_MSG Commit Message: Line 19: across minor versions (e.g. 3.5 to 3.6). Line 20: Line 21: This patch also makes room for future options which are Line 22: currently being discussed, like memory profiling or Line 23: a debug manhole service. To do this we much change the config names so we can have many profile_xxx_enable options, And make the lib/vdsm/profile.py a package: lib/vdsm/profile/cpu.py Line 24: Line 25: Change-Id: I7f9fc14c6fffd7ba111af985586eada83ec3c345 http://gerrit.ovirt.org/#/c/32664/1/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 339: Line 340: # Section: [devel] Line 341: ('devel', [ Line 342: Line 343: ('profile_enable', 'false', Lests make room for the memory profiler by renaming all "profile_" configs to "profile_cpu". We can do this in another patch, but I don't a need. This patch: make room for more profilers Next patch: add memory profiler What do you think? Line 344: 'Enable whole process profiling (requires yappi profiler).'), Line 345: Line 346: ('profile_format', 'pstat', Line 347: 'Profile file format (pstat, callgrind, ystat)'), -- To view, visit http://gerrit.ovirt.org/32664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f9fc14c6fffd7ba111af985586eada83ec3c345 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
