Dan Kenigsberg has posted comments on this change. Change subject: vm: per-attribute monitor response check ......................................................................
Patch Set 11: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/23138/11/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2837: if (not self.isMigrating() Line 2838: and decStats['statsAge'] > Line 2839: config.getint('vars', 'vm_command_timeout')): Line 2840: stats['monitorResponse'] = '-1' Line 2841: self.log.warning('monitor unresponsive' I do not recall (or understand) why we needed to have this explicit additional stats['monitorResponse'] = '-1' and the added log line does not help me at all. To understand this issue better, please make the wording more readable, add this log only when stats['monitorResponse'] is not -1 already. Line 2842: ' for stats too old') Line 2843: except Exception: Line 2844: self.log.error("Error fetching vm stats", exc_info=True) Line 2845: for var in decStats: Line 3881: Line 3882: def isResponsive(self): Line 3883: if self._vmStats: Line 3884: return self._responsive and self._vmStats.isResponsive() Line 3885: return self._responsive as it stands, nothing clears a temporary self._responsive==False. If a non-sampling command fails once, the VM is stuck in non-responisive for ever. We need to have a moratorium on this, or some other idea. Line 3886: Line 3887: def _waitForIncomingMigrationFinish(self): Line 3888: if 'restoreState' in self.conf: Line 3889: self.cont() -- To view, visit http://gerrit.ovirt.org/23138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32a98d34cde91fa9dc3d07f03c47a5f2f22da620 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
