Francesco Romani has posted comments on this change. Change subject: vm: migration: exponential downtime increment ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25820/6/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 353: if not self._preparingMigrationEvt: Line 354: raise Line 355: Line 356: Line 357: def exponential_downtime(downtime, steps): > would you add a unit test for this function? Because you're right, and I had a bug in my formula. Better to quickly hide this from my calculus professor :) Line 358: offset = downtime - (downtime / steps) Line 359: base = (downtime - offset) ** (1 / float(steps)) Line 360: Line 361: for i in range(steps): -- To view, visit http://gerrit.ovirt.org/25820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
