Francesco Romani has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml ......................................................................
Patch Set 3: The simple creation flow looks OK. I'm concerned with migrations, both live migrations and hibernation/restore (both these paths happen to share a lot of common code) At glance, the filtering you added may be sufficient. Otherwise, we probably need to filter out the configuration param 'memGuaranteedSize' in the Vm.__init__() method - maybe with an added warning. -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
