Francesco Romani has posted comments on this change. Change subject: tests: split tests fakes in a module ......................................................................
Patch Set 3: Verified+1 renamed vmtestlib -> vmfakelib renamed Fake* -> fake.* into client code renamed ConnectionMock to Connection along the way renamed fake.Vm() instances to 'testvm' (instead of the poorly-choosed 'fake' used previously) to avoid name clash - also a bit nicer. Ticking 'V+1' because all test pass cleanly -- To view, visit http://gerrit.ovirt.org/32650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7bb1d38d3814c406a53e1b7dbcac34eb6ffeb7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
