Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Use frozenset instead of set ......................................................................
tests: Use frozenset instead of set Using frozenset ensures that bad code trying ot mutate the return value of requires() will fail. Instead of replacing all set(...) calls with frozenset(...), I'm creating the frozenset in __init__, so there is no way to create an instance with the wrong type. This also cleans up code that creates a mock configurator without any requirements. Change-Id: I11835fe49ffcc3e4cbfdbc4272bc31429b6be2e1 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/31786 Reviewed-by: mooli tayer <mta...@redhat.com> Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M tests/toolTests.py 1 file changed, 25 insertions(+), 26 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11835fe49ffcc3e4cbfdbc4272bc31429b6be2e1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
