Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2872 Line 2873 Line 2874 Line 2875 Line 2876 > IMO comments goes before: We have different flows here, so better have a comment for each flow. Lets not make it harder for Fabio, just keep the structure that was before. -- To view, visit http://gerrit.ovirt.org/32796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabio Pliger <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Fabio Pliger <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
