Nir Soffer has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/31534/12/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 110: Line 111: pattern = os.path.join(_DEVPLATFORM_PATH, 'host*', 'session%s' % sessionID) Line 112: for path in glob.glob(pattern): Line 113: session_host = os.path.basename(os.path.split(path)[0]) Line 114: return os.path.join(_ISCSIHOST_PATH, session_host) > .. but please use glob.iglob to avoid possibly-long intermediate list. .. but in this case there can be only one item Line 115: Line 116: raise OSError(errno.ENOENT, "No iscsi_host for session [%s]" % sessionID) Line 117: Line 118: -- To view, visit http://gerrit.ovirt.org/31534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
