Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Use more clear name ......................................................................
tests: Use more clear name false_mock is misterious name, specially when used as false_mock=False. Reading the code reveal that false_mock=True means that the mock should fail. Hopefully renming it to should_fail will make this more clear. When creating a mock, using optional argument notation "should_fail=True" is more clear then just "True". Change-Id: I0697923fb18eb0d7d35e8044da7f6b4f8ee9d051 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/32726 Reviewed-by: mooli tayer <[email protected]> Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/toolTests.py 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Nir Soffer: Verified mooli tayer: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0697923fb18eb0d7d35e8044da7f6b4f8ee9d051 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
