Yeela Kaplan has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator ......................................................................
Patch Set 9: (4 comments) http://gerrit.ovirt.org/#/c/30909/9//COMMIT_MSG Commit Message: Line 11: Line 12: multipath.conf should not be changed since important changes Line 13: done by the sysadmin are needed and might be overwritten. Line 14: Line 15: Now it will be reconfigured only on user demand. > While all this is correct, it does not emphasize the important change: Done Line 16: Line 17: Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Line 18: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1076531 http://gerrit.ovirt.org/#/c/30909/9/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 41: _CONFIGURATORS = dict((m.name, m) for m in ( Line 42: certificates.Certificates(), Line 43: libvirt.Libvirt(), Line 44: sanlock.Sanlock(), Line 45: multipath.Multipath(), > you need to rebase again (http://gerrit.ovirt.org/31775) Done Line 46: )) Line 47: Line 48: Line 49: @expose("configure") http://gerrit.ovirt.org/#/c/30909/9/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 62: "}\n" Line 63: "}" Line 64: ) Line 65: Line 66: _MAX_CONF_COPIES = 5 > Lets not change this in this patch. I don't understand why this is better a OK Line 67: Line 68: # conf file configured by vdsm should contain a tag Line 69: # in form of "RHEV REVISION X.Y" Line 70: _OLD_TAGS = ["# RHAT REVISION 0.2", "# RHEV REVISION 0.3", Line 169: Line 170: for tag in self._OLD_TAGS: Line 171: if tag in first: Line 172: sys.stdout.write("Downrev multipath.conf detected, " Line 173: "upgrade required\n") > This means that multipath.conf was configured by old vdsm version, and we n OK Line 174: return NOT_CONFIGURED Line 175: Line 176: sys.stdout.write("multipath requires configuration\n") -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches