Nir Soffer has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename ......................................................................
Patch Set 14: Code-Review+1 (1 comment) Looks ok, hopefully we can fix engine be consistent with other parameters. http://gerrit.ovirt.org/#/c/31534/14/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 232: target = iscsi.IscsiTarget(portal, tpgt, conDict.get('iqn', None)) Line 233: Line 234: iface = _resolveIscsiIface(conDict.get('ifaceName', None), Line 235: conDict.get('initiatorName', None), Line 236: conDict.get('netIfacename', None)) Can we fix engine to send "netIfaceName"? Line 237: Line 238: cred = None Line 239: username = conDict.get('user', None) Line 240: password = conDict.get('password', None) -- To view, visit http://gerrit.ovirt.org/31534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
