Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Stop NetworkManager from ifup'ing our reference bond ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33227/4/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 428: if has_nm: Line 429: nmcli = _NM_CLI_BINARY.cmd Line 430: ifcfgPath = NET_CONF_PREF + interface Line 431: execCmd([_TEE_BINARY.cmd, ifcfgPath], sudo=True, Line 432: data='DEVICE=%s\nNM_CONTROLLED=no\n' % interface) > Since this becomes so complex, and since you report that Yes, execCmd([nmcli, 'conn', 'delete', interface], sudo=True) causes NM to crash. I will post the conversion into a vdsm-tool as a follow-up patch not to lose continuity, do you agree? Line 433: Line 434: rc, _, _ = execCmd([nmcli, 'conn', 'load', ifcfgPath], sudo=True) Line 435: if rc: Line 436: raise RuntimeError('Failed to unmanage %s.' % interface) -- To view, visit http://gerrit.ovirt.org/33227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff14c4791355f05890805a8d6b5208e7adb0ef7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
