Nir Soffer has posted comments on this change. Change subject: spec: split qemu-kvm* requirement to its own %if ......................................................................
Patch Set 1: (1 comment) Nice, It would be nice to get some more info on the commit message. http://gerrit.ovirt.org/#/c/33378/1//COMMIT_MSG Commit Message: Line 8: Line 9: qemu-kvm* dependency is about to become even more complex, and as such Line 10: it is granted a special %if section. One of the three occurences of Line 11: qemu-kvm-rhev can be dropped, since el6's current requirement equally Line 12: applies to el7. Can you explain in the commit message why we did not require specific version for qemu-kvm (still true for other packages)? Experience with recent builds of non-intel rhel7 show that rhel 7 packages (lvm) may be *older* than rhel 6 packages. Line 13: Line 14: Change-Id: I088eee894b631d9f864d6b7563877bf3ac76a9f3 -- To view, visit http://gerrit.ovirt.org/33378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I088eee894b631d9f864d6b7563877bf3ac76a9f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
