Dan Kenigsberg has posted comments on this change. Change subject: vdsm: introduce hostdev module ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/32313/10/vdsm/hostdev.py File vdsm/hostdev.py: Line 70: Line 71: for device in VM.conf['devices']: Line 72: if device['device'] == 'hostdev': Line 73: try: Line 74: devices[device['name']] = vmId > PS8 was clearer in my opinion. More importantly - is there any possibility to have a hostdev with no "name"? If so, our code does not support it (we do not report its assignment properly). If nameless hostdevs are impossible, finding one is not a warning, it is an error (which I'd rather not swallow). Line 75: except KeyError: Line 76: raise logging.warn('Vm %s has hostdev without mandatory ' Line 77: 'name attribute!', vmId) Line 78: -- To view, visit http://gerrit.ovirt.org/32313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
