Hello Federico Simoncelli, Dan Kenigsberg, I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33418 to review the following change. Change subject: spec: do not require qemu-kvm-rhev on Fedora ...................................................................... spec: do not require qemu-kvm-rhev on Fedora qemu-kvm-rhev is required for oVirt's feature completeness. However it is not shipped within Fedora. When Vdsm is built for Fedora, we cannot require it. However, when built for oVirt and downstream RHEV, it is simpler and nicer to have a strict hard requirement. Change-Id: If272983362d5b0f11d0925c64315a046d3b144d0 Signed-off-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/33367 Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> --- M vdsm.spec.in 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/33418/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 66427e1..5d1ef5e 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -218,6 +218,21 @@ Requires: systemd >= 197-1.fc18.2 %endif +%if !%{fedora_koji_build} +%global rhev_suffix -rhev +%endif + +%if 0%{?rhel} +%if 0%{?rhel} >= 7 +Requires: qemu-kvm%{?rhev_suffix} +Requires: qemu-img%{?rhev_suffix} +%else +Requires: qemu-kvm%{?rhev_suffix} >= 2:0.12.1.2-2.415.el6_5.3 +Requires: qemu-img%{?rhev_suffix} >= 2:0.12.1.2-2.415.el6_5.3 +%endif +%else +Requires: qemu-kvm >= 2:0.15.0-4 +Requires: qemu-img >= 2:0.15.0-4 %endif # GlusterFS client-side RPMs needed for Gluster SD -- To view, visit http://gerrit.ovirt.org/33418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If272983362d5b0f11d0925c64315a046d3b144d0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches