David Caro has posted comments on this change.

Change subject: tool-tests: use variable from conf version in template files.
......................................................................


Patch Set 5:

Three issues I see:

A real one related to the code:
  ./tests/toolTests.py:309: undefined name 'Libvirt'


One related to stall yum metadata (or so it seems):
  failure: 
repodata/c5c33bcb408dc935d117c85c76835f93eaadde4a333523ebd404a8b9b9707f33-primary.sqlite.bz2
 from epel-testing: [Errno 256] No more mirrors to try.


And one related to gluster rpms on el6:
  error: lua script failed: [string 
"%pretrans(glusterfs-libs-3.4.0.57rhs-1.el6_5.x86_64)"]:40: bad argument #2 to 
'error' (number expected, got boolean)


The first you should fix, the second I should fix, and the third needs some 
input from someone from gluster, do you know anyone there on gluster?

-- 
To view, visit http://gerrit.ovirt.org/32713
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to