Francesco Romani has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check ......................................................................
Patch Set 2: Verified+1 Verification (against locally patched vdsm-4.16.5-5.gitb16b036.el6.x86_64 , but relevant code path are identical) - live storage migration flow is broken (https://bugzilla.redhat.com/show_bug.cgi?id=1147971#c0) - live merge not available due to libvirt limitations - so I had to play with disk hotplug/hotunplug, which is good enough as soon as a diks disappears under VDSM's nose. - tuned VDSM to do more frequent polling: vm_sample_disk_interval = 1 vm_sample_disk_latency_interval = 1 - added watch to exercise the code path: - watch vdsClient -s 0 getAllVmStats the two above will significantly increase the chance to trigger the error being addressed by this change. On a VM with three disks (main plus two auxiliary) - plugged/unplugged at random sequence/times the two auxiliary disk - snooped the vdsm logs for errors - verified the entries appears and disappears from vdsClient output did the above for ~10 cycles -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches