Dan Kenigsberg has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33611/1//COMMIT_MSG Commit Message: Line 9: When rebooting host most of the times ssl_accept blocks when there is Line 10: new connection estabilished just after socket is opened. Setting timeout Line 11: on socket seems to help but when testing I noticed sometimes there is Line 12: still connection blocked on ssl_accept. Line 13: And more importantly, without this timeout, it is SO easy to DoS us. Please add a test that verifies that opening a plaintext TCP connection to an SSL server does not block us, and backport as far as you can. Line 14: Line 15: Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
