Martin Polednik has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 570: try: Line 571: if (sInfo and vmDrive.name in sInfo and Line 572: eInfo and vmDrive.name in eInfo): Line 573: dStats = self._calcDiskLatency(vmDrive, sInfo, eInfo) Line 574: except (KeyError, TypeError): > The if block is required, we don't want to log exceptions when vmDrive.name These were meant if the "if" could be dropped, wasn't aware of the logging issue so ignore Line 575: self._log.exception("Disk %s latency not available", Line 576: vmDrive.name) Line 577: Line 578: stats[vmDrive.name].update(dStats) -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
