Dan Kenigsberg has submitted this change and it was merged.
Change subject: volume: Fix exception re-rasing
......................................................................
volume: Fix exception re-rasing
When re-raising and excepition, the correct way is:
raise
And not:
raise e
The later form create a new useless traceback, strating at the point were the
exception was re-raised:
Traceback (most recent call last):
File "raise.py", line 14, in <module>
raise e
Exception: testing
Instead of the original traceback, showing the original call stack:
Traceback (most recent call last):
File "raise.py", line 11, in <module>
a()
File "raise.py", line 2, in a
b()
File "raise.py", line 5, in b
c()
File "raise.py", line 8, in c
raise Exception("testing")
Exception: testing
Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605
Signed-off-by: Nir Soffer <nsof...@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33556
Reviewed-by: Yeela Kaplan <ykap...@redhat.com>
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified
Yeela Kaplan: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
